master
Daan Vanoverloop 1 month ago
parent 3c8940aa6d
commit 1c9b8ce305
  1. 2
      Computergrafiek Project/graphics_project_21-22-Danacus
  2. BIN
      MCS/mcs.xopp
  3. 3
      MCS/review.md

@ -1 +1 @@
Subproject commit 12e8b4884e0ad2f4745b5898e8d508e0dd4c750d
Subproject commit e4a907759fa038ab93eab06bb31ff45fa4cbb580

Binary file not shown.

@ -15,11 +15,12 @@ Tibo:
- Easy to read and well documented.
- `URPartial` looks like a weird solution to a weird problem.
- It is considered a "common mistake" to not use preconditions/putting them inside the definitions, but I didn't do it either and disagree that this is a mistake. The code still looks very readable without them and they are mainly applicable in situations where there are multiple solutions to the problem, which is not the case here.
- `CanGoUp` and `ShouldGoUp` make it easier to read
Justas:
- It works.
- Helper functions are well chosen and make the rest of the code easier to understand.
- Well documented
- Good that you added the precondition for MakeRequest. Many people including me forgot it and lost points.
- Good that you added the precondition for `MakeRequest`. Many people including me forgot it and lost points.
- You don't actually need `Cn` when using functions (see page 113), but it's not wrong.

Loading…
Cancel
Save